|PR_LOGGING| is defined in "prlog.h", but we check for it prior to including "prlog.h" [1] We should just include prlog.h outside of the #define scope and then change the various |#if defined(DEBUG) || defined(PR_LOGGING)| to just |#if defined(PR_LOGGING)| [1] http://hg.mozilla.org/mozilla-central/annotate/5e704397529b/gfx/2d/Logging.h#l30

This is pretty basic. I unconditionally #include <prlog.h> and only look at PR_LOGGING.

try: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=51919550f276

Comment on attachment 8495408 [details] [diff] [review] Just use PR_LOGGING to determine if logging is enabled Review of attachment 8495408 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/2d/Logging.h @@ +9,5 @@ > #include <string> > #include <sstream> > #include <stdio.h> > > +#include <prlog.h> You can't unconditionally include this file inside Moz2D. Since it's not available in the stand-alone build.

Comment on attachment 8495408 [details] [diff] [review] Just use PR_LOGGING to determine if logging is enabled Review of attachment 8495408 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/2d/Logging.h @@ +9,5 @@ > #include <string> > #include <sstream> > #include <stdio.h> > > +#include <prlog.h> We currently do this in debug builds, so nothing has really changed. Unless we don't support stand-alone debug builds? If that's the case what would you suggest wrapping this include in?

Comment on attachment 8495408 [details] [diff] [review] Just use PR_LOGGING to determine if logging is enabled Review of attachment 8495408 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/2d/Logging.h @@ +9,5 @@ > #include <string> > #include <sstream> > #include <stdio.h> > > +#include <prlog.h> This is a recent change, it's good you pointed it out, ut's a little silly, Debug stand-alone builds don't define DEBUG (rather _DEBUG). It's actually a bug already, can we come up with a sane way of fixing this include, then I can fix the defining of DEBUG :).

MOZ_LOGGING should be sufficiently mozilla specific to keep prlog.h out of the standalone build. This should also fix bustage related to DEBUG builds on non-mozilla targets.

Comment on attachment 8500230 [details] [diff] [review] Just use PR_LOGGING to determine if logging is enabled Review of attachment 8500230 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me!

remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/ef7d6554b13d